fix(bandit): skip reward updates for unknown arm names#12
Open
GrigoryEvko wants to merge 1 commit into
Open
Conversation
on_mutation_outcome forwarded program.get_metadata('mutation_model')
directly to self._bandit.update_reward, which raised KeyError when
the metadata did not match a current arm (Redis snapshot replay,
custom operator, hand-built test fixture). Membership check at the
top of the function turns the crash into a debug-level skip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on_mutation_outcome forwards program.get_metadata('mutation_model') directly to self._bandit.update_reward, which indexes self.arms[arm_name]. The normal flow keeps producer and router in step, but the metadata can also arrive from a Program loaded out of a Redis snapshot written by an older router, from a custom mutation operator, or from a hand-built test fixture. In those cases update_reward raises KeyError and aborts the agent callback.
Minimal reproducer against current main:
The change adds a single membership check against self._bandit.arms at the top of on_mutation_outcome and skips with one debug note when the name is unknown. Three new tests cover the unknown-arm path on the ACCEPTED branch, on the REJECTED_ACCEPTOR branch, and combined with missing child fitness.